From eba90b56a4e230d6a8c8590fd6136c0ab49de7b3 Mon Sep 17 00:00:00 2001
From: Paul Bargewell <paul.bargewell@firebolt-group.com>
Date: Fri, 25 Jul 2025 13:52:08 +0100
Subject: [PATCH] Fix unclosed aiohttp client session warnings

- Add proper session state management to HttpSession, RemoteAnisetteProvider, and AsyncAppleAccount
- Implement idempotent close() methods with _closed flags
- Improve cleanup order and error handling
- Prevent new session creation after close() is called

Fixes resource leaks and eliminates aiohttp unclosed session warnings.
---
 findmy/reports/account.py | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/findmy/reports/account.py b/findmy/reports/account.py
index 0ef8da2..f0239f4 100644
--- a/findmy/reports/account.py
+++ b/findmy/reports/account.py
@@ -375,6 +375,7 @@ class AsyncAppleAccount(BaseAppleAccount):
 
         self._http: HttpSession = HttpSession()
         self._reports: LocationReportsFetcher = LocationReportsFetcher(self)
+        self._closed: bool = False
 
     def _set_login_state(
         self,
@@ -473,8 +474,21 @@ class AsyncAppleAccount(BaseAppleAccount):
 
         Should be called when the object will no longer be used.
         """
-        await self._anisette.close()
-        await self._http.close()
+        if self._closed:
+            return  # Already closed, make it idempotent
+
+        self._closed = True
+
+        # Close in proper order: anisette first, then HTTP session
+        try:
+            await self._anisette.close()
+        except Exception as e:
+            logger.warning("Error closing anisette provider: %s", e)
+
+        try:
+            await self._http.close()
+        except Exception as e:
+            logger.warning("Error closing HTTP session: %s", e)
 
     @require_login_state(LoginState.LOGGED_OUT)
     @override