From ff647b86a2bc7ae8d72885c419e3134475d13159 Mon Sep 17 00:00:00 2001 From: Benjamin Harder Date: Sat, 25 Oct 2025 22:54:02 +0200 Subject: [PATCH 1/4] Remove redundant warning --- src/settings/_jobs.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/settings/_jobs.py b/src/settings/_jobs.py index aa84d44..716b55a 100644 --- a/src/settings/_jobs.py +++ b/src/settings/_jobs.py @@ -32,10 +32,6 @@ class JobParams: self.max_concurrent_searches = max_concurrent_searches self.min_days_between_searches = min_days_between_searches - # if not self.max_concurrent_searches <= 0: - # logger.warning(f"Job setting 'max_concurrent_searches' must be an integer greater 0. Found: {str(self.max_concurrent_searches)}. Using default: 3") - # self.max_concurrent_searches = 3 - # Remove attributes that are None to keep the object clean self._remove_none_attributes() @@ -59,13 +55,7 @@ class JobDefaults: def __init__(self, config): job_defaults_config = config.get("job_defaults", {}) self.max_strikes = job_defaults_config.get("max_strikes", self.max_strikes) - max_concurrent_searches = job_defaults_config.get("max_concurrent_searches") - if isinstance(max_concurrent_searches, int) and max_concurrent_searches > 0: - self.max_concurrent_searches = max_concurrent_searches - else: - logger.warning( - f"Job default 'max_concurrent_searches' must be an integer greater 0. Found: {str(max_concurrent_searches)}. Using default: {self.max_concurrent_searches}" - ) + self.max_concurrent_searches = job_defaults_config.get("max_concurrent_searches") self.min_days_between_searches = job_defaults_config.get( "min_days_between_searches", self.min_days_between_searches, From b436e7d35da38843fc77c21c682ea5933b31fec4 Mon Sep 17 00:00:00 2001 From: Benjamin Harder Date: Sat, 25 Oct 2025 23:01:05 +0200 Subject: [PATCH 2/4] fix missing default for max_concurrent_searches --- src/settings/_jobs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/_jobs.py b/src/settings/_jobs.py index 716b55a..a873744 100644 --- a/src/settings/_jobs.py +++ b/src/settings/_jobs.py @@ -55,7 +55,7 @@ class JobDefaults: def __init__(self, config): job_defaults_config = config.get("job_defaults", {}) self.max_strikes = job_defaults_config.get("max_strikes", self.max_strikes) - self.max_concurrent_searches = job_defaults_config.get("max_concurrent_searches") + self.max_concurrent_searches = job_defaults_config.get("max_concurrent_searches", self.max_concurrent_searches) self.min_days_between_searches = job_defaults_config.get( "min_days_between_searches", self.min_days_between_searches, From bf7b07fde336ef596456729123de8e946bdae544 Mon Sep 17 00:00:00 2001 From: Benjamin Harder Date: Sat, 25 Oct 2025 23:01:50 +0200 Subject: [PATCH 3/4] fix trailing newlines --- src/settings/_general.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/settings/_general.py b/src/settings/_general.py index 2c0801d..5e9d590 100644 --- a/src/settings/_general.py +++ b/src/settings/_general.py @@ -71,5 +71,4 @@ class General: config_yaml = get_config_as_yaml( vars(self), ) - return config_yaml - + return config_yaml \ No newline at end of file From be2b2d0fb31c16bf0fa1c16fc600114069d3f805 Mon Sep 17 00:00:00 2001 From: Benjamin Harder Date: Sat, 25 Oct 2025 23:02:15 +0200 Subject: [PATCH 4/4] fix missing-final-newline --- src/settings/_general.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/settings/_general.py b/src/settings/_general.py index 5e9d590..ccd42a6 100644 --- a/src/settings/_general.py +++ b/src/settings/_general.py @@ -71,4 +71,4 @@ class General: config_yaml = get_config_as_yaml( vars(self), ) - return config_yaml \ No newline at end of file + return config_yaml