From 5dfac387a6fbf4edde50899290e881831761d414 Mon Sep 17 00:00:00 2001 From: Devon Rifkin Date: Mon, 13 Apr 2026 13:12:18 -0700 Subject: [PATCH] Revert "gemma4: fix nothink case renderer (#15553)" (#15556) This reverts commit 4d75f5da03ccdea757cb945ba47dac1c965ef717. --- model/renderers/gemma4.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/model/renderers/gemma4.go b/model/renderers/gemma4.go index 663435e7b..7b186af9e 100644 --- a/model/renderers/gemma4.go +++ b/model/renderers/gemma4.go @@ -40,7 +40,6 @@ func (r *Gemma4Renderer) Render(messages []api.Message, tools []api.Tool, thinkV // Emit system turn if there's a system/developer role, tools, or thinking. hasThink := thinkValue != nil && thinkValue.Bool() - thinkingExplicitlyDisabled := thinkValue != nil && thinkValue.IsBool() && !thinkValue.Bool() if hasSystemRole || len(tools) > 0 || hasThink { sb.WriteString("<|turn>system\n") if hasThink { @@ -125,7 +124,7 @@ func (r *Gemma4Renderer) Render(messages []api.Message, tools []api.Tool, thinkV // Generation prompt. if prevMessageType != "tool_response" && prevMessageType != "tool_call" { sb.WriteString("<|turn>model\n") - if !hasThink && !thinkingExplicitlyDisabled { + if !hasThink { sb.WriteString("<|channel>thought\n") } }