starred/ollama
1
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-04-18 03:54:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

launch: skip context length warning for MLX models and show model name (#15102)

Browse Source
This commit is contained in:
Parth Sareen
2026-03-27 15:01:33 -07:00
committed by GitHub
parent ac83ac20c4
commit b00bd1dfd4
2 changed files with 56 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
cmd/launch/launch_test.go
View File

@@ -1506,6 +1506,7 @@ func TestConfirmLowContextLength(t *testing.T) {
statusBody string
statusCode int
showParams string // Parameters field returned by /api/show
showBody string // full JSON body for /api/show (overrides showParams when set)
wantWarning bool
wantModelfile bool // true if warning should mention Modelfile
}{
@@ -1596,6 +1597,28 @@ func TestConfirmLowContextLength(t *testing.T) {
statusCode: http.StatusOK,
showParams: "SHOW_ERROR", // sentinel to make show return 500
},
{
name: "no warning for safetensors model with high context length",
models: []string{"qwen3.5"},
statusBody: `{"cloud":{},"context_length":32768}`,
statusCode: http.StatusOK,
showBody: `{"details":{"format":"safetensors"},"model_info":{"qwen3_5_moe.context_length":262144}}`,
},
{
name: "warns for safetensors model with low context length",
models: []string{"small-model"},
statusBody: `{"cloud":{},"context_length":32768}`,
statusCode: http.StatusOK,
showBody: `{"details":{"format":"safetensors"},"model_info":{"small.context_length":4096}}`,
wantWarning: true,
},
{
name: "no warning for safetensors model even when server context is low",
models: []string{"qwen3.5"},
statusBody: `{"cloud":{},"context_length":4096}`,
statusCode: http.StatusOK,
showBody: `{"details":{"format":"safetensors"},"model_info":{"qwen3_5_moe.context_length":262144}}`,
},
}
for _, tt := range tests {
@@ -1614,7 +1637,11 @@ func TestConfirmLowContextLength(t *testing.T) {
return
}
w.WriteHeader(http.StatusOK)
fmt.Fprintf(w, `{"parameters":%q}`, tt.showParams)
if tt.showBody != "" {
fmt.Fprint(w, tt.showBody)
} else {
fmt.Fprintf(w, `{"parameters":%q}`, tt.showParams)
}
return
}
http.NotFound(w, r)
@@ -1648,12 +1675,12 @@ func TestConfirmLowContextLength(t *testing.T) {
t.Fatalf("expected warning=%v, got output: %q", tt.wantWarning, output)
}
if tt.wantWarning && tt.wantModelfile {
if !strings.Contains(output, "Use the model:") {
if !strings.Contains(output, "Use the base model") {
t.Fatalf("expected parent model hint in output: %q", output)
}
}
if tt.wantWarning && !tt.wantModelfile {
if strings.Contains(output, "Use the model:") {
if strings.Contains(output, "Use the base model") {
t.Fatalf("expected server hint, not parent model hint in output: %q", output)
}
}