mirror of
https://github.com/ollama/ollama.git
synced 2026-04-24 17:55:43 +02:00
Compare commits
2 Commits
codex/fix-
...
v0.21.2-rc
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
590109c835 | ||
|
|
b4442c6d17 |
@@ -588,7 +588,7 @@ func (c *launcherClient) launchManagedSingleIntegration(ctx context.Context, nam
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
if (current == "" || needsConfigure || req.ModelOverride != "" || target != current) && !savedMatchesModels(saved, []string{target}) {
|
if needsConfigure || req.ModelOverride != "" || (current != "" && target != current) || !savedMatchesModels(saved, []string{target}) {
|
||||||
if err := prepareManagedSingleIntegration(name, runner, managed, target); err != nil {
|
if err := prepareManagedSingleIntegration(name, runner, managed, target); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -512,6 +512,65 @@ func TestLaunchIntegration_ManagedSingleIntegrationRewritesWhenSavedDiffers(t *t
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestLaunchIntegration_ManagedSingleIntegrationRewritesWhenLiveConfigDrifts(t *testing.T) {
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
setLaunchTestHome(t, tmpDir)
|
||||||
|
withInteractiveSession(t, true)
|
||||||
|
withLauncherHooks(t)
|
||||||
|
|
||||||
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||||
|
switch r.URL.Path {
|
||||||
|
case "/api/tags":
|
||||||
|
fmt.Fprint(w, `{"models":[{"name":"gemma4"},{"name":"qwen3:8b"}]}`)
|
||||||
|
case "/api/show":
|
||||||
|
fmt.Fprint(w, `{"model_info":{"general.context_length":131072}}`)
|
||||||
|
default:
|
||||||
|
http.NotFound(w, r)
|
||||||
|
}
|
||||||
|
}))
|
||||||
|
defer srv.Close()
|
||||||
|
t.Setenv("OLLAMA_HOST", srv.URL)
|
||||||
|
|
||||||
|
if err := config.SaveIntegration("stubmanaged", []string{"gemma4"}); err != nil {
|
||||||
|
t.Fatalf("failed to save managed integration config: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
runner := &launcherManagedRunner{
|
||||||
|
currentModel: "qwen3:8b",
|
||||||
|
}
|
||||||
|
withIntegrationOverride(t, "stubmanaged", runner)
|
||||||
|
|
||||||
|
DefaultSingleSelector = func(title string, items []ModelItem, current string) (string, error) {
|
||||||
|
t.Fatal("selector should not be called when live config already provides the target")
|
||||||
|
return "", nil
|
||||||
|
}
|
||||||
|
DefaultConfirmPrompt = func(prompt string, options ConfirmOptions) (bool, error) {
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := LaunchIntegration(context.Background(), IntegrationLaunchRequest{Name: "stubmanaged"}); err != nil {
|
||||||
|
t.Fatalf("LaunchIntegration returned error: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
if diff := compareStrings(runner.configured, []string{"qwen3:8b"}); diff != "" {
|
||||||
|
t.Fatalf("expected Configure to reconcile stale saved config to live target: %s", diff)
|
||||||
|
}
|
||||||
|
if runner.refreshCalls != 1 {
|
||||||
|
t.Fatalf("expected runtime refresh once after drift reconciliation, got %d", runner.refreshCalls)
|
||||||
|
}
|
||||||
|
if runner.ranModel != "qwen3:8b" {
|
||||||
|
t.Fatalf("expected launch to run live configured model, got %q", runner.ranModel)
|
||||||
|
}
|
||||||
|
|
||||||
|
saved, err := config.LoadIntegration("stubmanaged")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("failed to reload managed integration config: %v", err)
|
||||||
|
}
|
||||||
|
if diff := compareStrings(saved.Models, []string{"qwen3:8b"}); diff != "" {
|
||||||
|
t.Fatalf("saved models mismatch after drift reconciliation: %s", diff)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestLaunchIntegration_ManagedSingleIntegrationStopsWhenRuntimeRefreshFails(t *testing.T) {
|
func TestLaunchIntegration_ManagedSingleIntegrationStopsWhenRuntimeRefreshFails(t *testing.T) {
|
||||||
tmpDir := t.TempDir()
|
tmpDir := t.TempDir()
|
||||||
setLaunchTestHome(t, tmpDir)
|
setLaunchTestHome(t, tmpDir)
|
||||||
|
|||||||
@@ -28,6 +28,8 @@ var openclawModelShowTimeout = 5 * time.Second
|
|||||||
// openclawFreshInstall is set to true when ensureOpenclawInstalled performs an install
|
// openclawFreshInstall is set to true when ensureOpenclawInstalled performs an install
|
||||||
var openclawFreshInstall bool
|
var openclawFreshInstall bool
|
||||||
|
|
||||||
|
var openclawCanInstallDaemon = canInstallDaemon
|
||||||
|
|
||||||
type Openclaw struct{}
|
type Openclaw struct{}
|
||||||
|
|
||||||
func (c *Openclaw) String() string { return "OpenClaw" }
|
func (c *Openclaw) String() string { return "OpenClaw" }
|
||||||
@@ -58,6 +60,7 @@ func (c *Openclaw) Run(model string, args []string) error {
|
|||||||
// the newest wizard flags (e.g. --auth-choice ollama).
|
// the newest wizard flags (e.g. --auth-choice ollama).
|
||||||
if !openclawFreshInstall {
|
if !openclawFreshInstall {
|
||||||
update := exec.Command(bin, "update")
|
update := exec.Command(bin, "update")
|
||||||
|
update.Env = openclawInstallEnv()
|
||||||
update.Stdout = os.Stdout
|
update.Stdout = os.Stdout
|
||||||
update.Stderr = os.Stderr
|
update.Stderr = os.Stderr
|
||||||
_ = update.Run() // best-effort; continue even if update fails
|
_ = update.Run() // best-effort; continue even if update fails
|
||||||
@@ -73,19 +76,18 @@ func (c *Openclaw) Run(model string, args []string) error {
|
|||||||
"--auth-choice", "ollama",
|
"--auth-choice", "ollama",
|
||||||
"--custom-base-url", envconfig.Host().String(),
|
"--custom-base-url", envconfig.Host().String(),
|
||||||
"--custom-model-id", model,
|
"--custom-model-id", model,
|
||||||
|
// Launch owns the first real gateway startup immediately after onboarding,
|
||||||
|
// so don't let OpenClaw fail the whole first-run flow on a transient
|
||||||
|
// daemon health probe.
|
||||||
|
"--skip-health",
|
||||||
"--skip-channels",
|
"--skip-channels",
|
||||||
"--skip-skills",
|
"--skip-skills",
|
||||||
}
|
}
|
||||||
if canInstallDaemon() {
|
if openclawCanInstallDaemon() {
|
||||||
onboardArgs = append(onboardArgs, "--install-daemon")
|
onboardArgs = append(onboardArgs, "--install-daemon")
|
||||||
} else {
|
|
||||||
// When we can't install a daemon (e.g. no systemd, sudo dropped
|
|
||||||
// XDG_RUNTIME_DIR, or container environment), skip the gateway
|
|
||||||
// health check so non-interactive onboarding completes. The
|
|
||||||
// gateway is started as a foreground child process after onboarding.
|
|
||||||
onboardArgs = append(onboardArgs, "--skip-health")
|
|
||||||
}
|
}
|
||||||
cmd := exec.Command(bin, onboardArgs...)
|
cmd := exec.Command(bin, onboardArgs...)
|
||||||
|
cmd.Env = openclawInstallEnv()
|
||||||
cmd.Stdin = os.Stdin
|
cmd.Stdin = os.Stdin
|
||||||
cmd.Stdout = os.Stdout
|
cmd.Stdout = os.Stdout
|
||||||
cmd.Stderr = os.Stderr
|
cmd.Stderr = os.Stderr
|
||||||
@@ -101,6 +103,18 @@ func (c *Openclaw) Run(model string, args []string) error {
|
|||||||
// When extra args are passed through, run exactly what the user asked for
|
// When extra args are passed through, run exactly what the user asked for
|
||||||
// after setup and skip the built-in gateway+TUI convenience flow.
|
// after setup and skip the built-in gateway+TUI convenience flow.
|
||||||
if len(args) > 0 {
|
if len(args) > 0 {
|
||||||
|
cleanup := func() {}
|
||||||
|
if shouldEnsureGatewayForArgs(args) {
|
||||||
|
cleanupFn, _, _, err := c.ensureGatewayReady(bin)
|
||||||
|
if err != nil {
|
||||||
|
return windowsHint(err)
|
||||||
|
}
|
||||||
|
if cleanupFn != nil {
|
||||||
|
cleanup = cleanupFn
|
||||||
|
}
|
||||||
|
}
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
cmd := exec.Command(bin, args...)
|
cmd := exec.Command(bin, args...)
|
||||||
cmd.Env = openclawEnv()
|
cmd.Env = openclawEnv()
|
||||||
cmd.Stdin = os.Stdin
|
cmd.Stdin = os.Stdin
|
||||||
@@ -121,41 +135,11 @@ func (c *Openclaw) Run(model string, args []string) error {
|
|||||||
|
|
||||||
fmt.Fprintf(os.Stderr, "\n%sStarting your assistant — this may take a moment...%s\n\n", ansiGray, ansiReset)
|
fmt.Fprintf(os.Stderr, "\n%sStarting your assistant — this may take a moment...%s\n\n", ansiGray, ansiReset)
|
||||||
|
|
||||||
token, port := c.gatewayInfo()
|
cleanup, token, port, err := c.ensureGatewayReady(bin)
|
||||||
addr := fmt.Sprintf("localhost:%d", port)
|
if err != nil {
|
||||||
|
return windowsHint(err)
|
||||||
// If the gateway is already running (e.g. via the daemon), restart it
|
|
||||||
// so it picks up any config changes (model, provider, etc.).
|
|
||||||
if portOpen(addr) {
|
|
||||||
restart := exec.Command(bin, "daemon", "restart")
|
|
||||||
restart.Env = openclawEnv()
|
|
||||||
if err := restart.Run(); err != nil {
|
|
||||||
fmt.Fprintf(os.Stderr, "%s Warning: daemon restart failed: %v%s\n", ansiYellow, err, ansiReset)
|
|
||||||
}
|
|
||||||
if !waitForPort(addr, 10*time.Second) {
|
|
||||||
fmt.Fprintf(os.Stderr, "%s Warning: gateway did not come back after restart%s\n", ansiYellow, ansiReset)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// If the gateway isn't running, start it as a background child process.
|
|
||||||
if !portOpen(addr) {
|
|
||||||
gw := exec.Command(bin, "gateway", "run", "--force")
|
|
||||||
gw.Env = openclawEnv()
|
|
||||||
if err := gw.Start(); err != nil {
|
|
||||||
return windowsHint(fmt.Errorf("failed to start gateway: %w", err))
|
|
||||||
}
|
|
||||||
defer func() {
|
|
||||||
if gw.Process != nil {
|
|
||||||
_ = gw.Process.Kill()
|
|
||||||
_ = gw.Wait()
|
|
||||||
}
|
|
||||||
}()
|
|
||||||
}
|
|
||||||
|
|
||||||
fmt.Fprintf(os.Stderr, "%sStarting gateway...%s\n", ansiGray, ansiReset)
|
|
||||||
if !waitForPort(addr, 30*time.Second) {
|
|
||||||
return windowsHint(fmt.Errorf("gateway did not start on %s", addr))
|
|
||||||
}
|
}
|
||||||
|
defer cleanup()
|
||||||
|
|
||||||
printOpenclawReady(bin, token, port, firstLaunch)
|
printOpenclawReady(bin, token, port, firstLaunch)
|
||||||
|
|
||||||
@@ -175,6 +159,66 @@ func (c *Openclaw) Run(model string, args []string) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func shouldEnsureGatewayForArgs(args []string) bool {
|
||||||
|
return len(args) > 0 && args[0] == "tui"
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *Openclaw) ensureGatewayReady(bin string) (func(), string, int, error) {
|
||||||
|
token, port := c.gatewayInfo()
|
||||||
|
addr := fmt.Sprintf("localhost:%d", port)
|
||||||
|
|
||||||
|
// If the gateway is already running (e.g. via the daemon), restart it
|
||||||
|
// so it picks up any config changes (model, provider, etc.).
|
||||||
|
if portOpen(addr) {
|
||||||
|
restart := exec.Command(bin, "daemon", "restart")
|
||||||
|
restart.Env = openclawEnv()
|
||||||
|
if err := restart.Run(); err != nil {
|
||||||
|
fmt.Fprintf(os.Stderr, "%s Warning: daemon restart failed: %v%s\n", ansiYellow, err, ansiReset)
|
||||||
|
}
|
||||||
|
if !waitForPort(addr, 10*time.Second) {
|
||||||
|
fmt.Fprintf(os.Stderr, "%s Warning: gateway did not come back after restart%s\n", ansiYellow, ansiReset)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// If the daemon is installed but not currently listening, try to bring it
|
||||||
|
// up before falling back to a foreground child process.
|
||||||
|
if openclawCanInstallDaemon() && !portOpen(addr) {
|
||||||
|
start := exec.Command(bin, "daemon", "start")
|
||||||
|
start.Env = openclawEnv()
|
||||||
|
if err := start.Run(); err != nil {
|
||||||
|
fmt.Fprintf(os.Stderr, "%s Warning: daemon start failed: %v%s\n", ansiYellow, err, ansiReset)
|
||||||
|
} else if waitForPort(addr, 10*time.Second) {
|
||||||
|
fmt.Fprintf(os.Stderr, "%sStarting gateway...%s\n", ansiGray, ansiReset)
|
||||||
|
return func() {}, token, port, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
cleanup := func() {}
|
||||||
|
|
||||||
|
// If the gateway still isn't running, start it as a background child process.
|
||||||
|
if !portOpen(addr) {
|
||||||
|
gw := exec.Command(bin, "gateway", "run", "--force")
|
||||||
|
gw.Env = openclawEnv()
|
||||||
|
if err := gw.Start(); err != nil {
|
||||||
|
return nil, "", 0, fmt.Errorf("failed to start gateway: %w", err)
|
||||||
|
}
|
||||||
|
cleanup = func() {
|
||||||
|
if gw.Process != nil {
|
||||||
|
_ = gw.Process.Kill()
|
||||||
|
_ = gw.Wait()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fmt.Fprintf(os.Stderr, "%sStarting gateway...%s\n", ansiGray, ansiReset)
|
||||||
|
if !waitForPort(addr, 30*time.Second) {
|
||||||
|
cleanup()
|
||||||
|
return nil, "", 0, fmt.Errorf("gateway did not start on %s", addr)
|
||||||
|
}
|
||||||
|
|
||||||
|
return cleanup, token, port, nil
|
||||||
|
}
|
||||||
|
|
||||||
// runChannelSetupPreflight prompts users to connect a messaging channel before
|
// runChannelSetupPreflight prompts users to connect a messaging channel before
|
||||||
// starting the built-in gateway+TUI flow. In interactive sessions, it loops
|
// starting the built-in gateway+TUI flow. In interactive sessions, it loops
|
||||||
// until a channel is configured, unless the user chooses "Set up later".
|
// until a channel is configured, unless the user chooses "Set up later".
|
||||||
@@ -335,9 +379,30 @@ func openclawEnv() []string {
|
|||||||
env = append(env, e)
|
env = append(env, e)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
if _, ok := os.LookupEnv("OPENCLAW_PLUGIN_STAGE_DIR"); !ok {
|
||||||
|
if dir := openclawPluginStageDir(); dir != "" {
|
||||||
|
env = append(env, "OPENCLAW_PLUGIN_STAGE_DIR="+dir)
|
||||||
|
}
|
||||||
|
}
|
||||||
return env
|
return env
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func openclawInstallEnv() []string {
|
||||||
|
env := openclawEnv()
|
||||||
|
if _, ok := os.LookupEnv("OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"); !ok {
|
||||||
|
env = append(env, "OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS=1")
|
||||||
|
}
|
||||||
|
return env
|
||||||
|
}
|
||||||
|
|
||||||
|
func openclawPluginStageDir() string {
|
||||||
|
home, err := os.UserHomeDir()
|
||||||
|
if err != nil {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
return filepath.Join(home, ".openclaw", "plugin-runtime-deps")
|
||||||
|
}
|
||||||
|
|
||||||
// portOpen checks if a TCP port is currently accepting connections.
|
// portOpen checks if a TCP port is currently accepting connections.
|
||||||
func portOpen(addr string) bool {
|
func portOpen(addr string) bool {
|
||||||
conn, err := net.DialTimeout("tcp", addr, 500*time.Millisecond)
|
conn, err := net.DialTimeout("tcp", addr, 500*time.Millisecond)
|
||||||
@@ -561,6 +626,7 @@ func ensureOpenclawInstalled() (string, error) {
|
|||||||
|
|
||||||
fmt.Fprintf(os.Stderr, "\nInstalling OpenClaw...\n")
|
fmt.Fprintf(os.Stderr, "\nInstalling OpenClaw...\n")
|
||||||
cmd := exec.Command("npm", "install", "-g", "openclaw@latest")
|
cmd := exec.Command("npm", "install", "-g", "openclaw@latest")
|
||||||
|
cmd.Env = openclawInstallEnv()
|
||||||
cmd.Stdin = os.Stdin
|
cmd.Stdin = os.Stdin
|
||||||
cmd.Stdout = os.Stdout
|
cmd.Stdout = os.Stdout
|
||||||
cmd.Stderr = os.Stderr
|
cmd.Stderr = os.Stderr
|
||||||
|
|||||||
@@ -251,6 +251,359 @@ func TestOpenclawRun_SetupLaterContinuesToGatewayAndTUI(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestOpenclawRun_FirstLaunchOnboardUsesLaunchManagedHealthFlow(t *testing.T) {
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
t.Skip("uses a POSIX shell test binary")
|
||||||
|
}
|
||||||
|
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
setTestHome(t, tmpDir)
|
||||||
|
t.Setenv("PATH", tmpDir)
|
||||||
|
|
||||||
|
bin := filepath.Join(tmpDir, "openclaw")
|
||||||
|
script := fmt.Sprintf(`#!/bin/sh
|
||||||
|
printf '%%s\n' "$*" >> "$HOME/invocations.log"
|
||||||
|
if [ "$1" = "onboard" ]; then
|
||||||
|
/usr/bin/env | /usr/bin/sort > "$HOME/onboard-env.log"
|
||||||
|
/bin/mkdir -p "$HOME/.openclaw"
|
||||||
|
/bin/cat > "$HOME/.openclaw/openclaw.json" <<'EOF'
|
||||||
|
{"wizard":{"lastRunAt":"2026-01-01T00:00:00Z"},"gateway":{"port":18789,"mode":"local"}}
|
||||||
|
EOF
|
||||||
|
fi
|
||||||
|
exit 0
|
||||||
|
`)
|
||||||
|
if err := os.WriteFile(bin, []byte(script), 0o755); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
oldConfirmPrompt := DefaultConfirmPrompt
|
||||||
|
DefaultConfirmPrompt = func(prompt string, options ConfirmOptions) (bool, error) {
|
||||||
|
if prompt != "I understand the risks. Continue?" {
|
||||||
|
t.Fatalf("unexpected prompt: %q", prompt)
|
||||||
|
}
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
defer func() { DefaultConfirmPrompt = oldConfirmPrompt }()
|
||||||
|
|
||||||
|
c := &Openclaw{}
|
||||||
|
if err := c.Run("llama3.2", []string{"status"}); err != nil {
|
||||||
|
t.Fatalf("Run() error = %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
data, err := os.ReadFile(filepath.Join(tmpDir, "invocations.log"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
lines := strings.Split(strings.TrimSpace(string(data)), "\n")
|
||||||
|
if len(lines) < 2 {
|
||||||
|
t.Fatalf("expected onboard + passthrough invocations, got %v", lines)
|
||||||
|
}
|
||||||
|
onboardInvocation := ""
|
||||||
|
for _, line := range lines {
|
||||||
|
if strings.HasPrefix(line, "onboard ") {
|
||||||
|
onboardInvocation = line
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if onboardInvocation == "" {
|
||||||
|
t.Fatalf("expected onboard invocation, got %v", lines)
|
||||||
|
}
|
||||||
|
if !strings.Contains(onboardInvocation, "--skip-health") {
|
||||||
|
t.Fatalf("expected onboard invocation to include --skip-health, got %q", onboardInvocation)
|
||||||
|
}
|
||||||
|
|
||||||
|
envData, err := os.ReadFile(filepath.Join(tmpDir, "onboard-env.log"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
env := envSliceToMap(strings.Split(strings.TrimSpace(string(envData)), "\n"))
|
||||||
|
if env["OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"] != "1" {
|
||||||
|
t.Fatalf("OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS = %q, want %q", env["OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"], "1")
|
||||||
|
}
|
||||||
|
if env["OPENCLAW_PLUGIN_STAGE_DIR"] != filepath.Join(tmpDir, ".openclaw", "plugin-runtime-deps") {
|
||||||
|
t.Fatalf("OPENCLAW_PLUGIN_STAGE_DIR = %q, want %q", env["OPENCLAW_PLUGIN_STAGE_DIR"], filepath.Join(tmpDir, ".openclaw", "plugin-runtime-deps"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOpenclawRun_FirstLaunchTUIArgsEnsureGatewayBeforePassthrough(t *testing.T) {
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
t.Skip("uses a POSIX shell test binary")
|
||||||
|
}
|
||||||
|
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
setTestHome(t, tmpDir)
|
||||||
|
t.Setenv("PATH", tmpDir)
|
||||||
|
|
||||||
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
defer ln.Close()
|
||||||
|
port := ln.Addr().(*net.TCPAddr).Port
|
||||||
|
|
||||||
|
bin := filepath.Join(tmpDir, "openclaw")
|
||||||
|
script := fmt.Sprintf(`#!/bin/sh
|
||||||
|
printf '%%s\n' "$*" >> "$HOME/invocations.log"
|
||||||
|
if [ "$1" = "onboard" ]; then
|
||||||
|
/bin/mkdir -p "$HOME/.openclaw"
|
||||||
|
/bin/cat > "$HOME/.openclaw/openclaw.json" <<'EOF'
|
||||||
|
{"wizard":{"lastRunAt":"2026-01-01T00:00:00Z"},"gateway":{"port":%d,"mode":"local"}}
|
||||||
|
EOF
|
||||||
|
fi
|
||||||
|
exit 0
|
||||||
|
`, port)
|
||||||
|
if err := os.WriteFile(bin, []byte(script), 0o755); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
oldConfirmPrompt := DefaultConfirmPrompt
|
||||||
|
DefaultConfirmPrompt = func(prompt string, options ConfirmOptions) (bool, error) {
|
||||||
|
if prompt != "I understand the risks. Continue?" {
|
||||||
|
t.Fatalf("unexpected prompt: %q", prompt)
|
||||||
|
}
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
defer func() { DefaultConfirmPrompt = oldConfirmPrompt }()
|
||||||
|
|
||||||
|
c := &Openclaw{}
|
||||||
|
if err := c.Run("llama3.2", []string{"tui"}); err != nil {
|
||||||
|
t.Fatalf("Run() error = %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
data, err := os.ReadFile(filepath.Join(tmpDir, "invocations.log"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
lines := strings.Split(strings.TrimSpace(string(data)), "\n")
|
||||||
|
if len(lines) < 3 {
|
||||||
|
t.Fatalf("expected at least 3 invocations (update, onboard, daemon restart, tui), got %v", lines)
|
||||||
|
}
|
||||||
|
onboardIdx, daemonRestartIdx, tuiIdx := -1, -1, -1
|
||||||
|
for i, line := range lines {
|
||||||
|
if onboardIdx == -1 && strings.HasPrefix(line, "onboard ") {
|
||||||
|
onboardIdx = i
|
||||||
|
}
|
||||||
|
if daemonRestartIdx == -1 && line == "daemon restart" {
|
||||||
|
daemonRestartIdx = i
|
||||||
|
}
|
||||||
|
if tuiIdx == -1 && line == "tui" {
|
||||||
|
tuiIdx = i
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if onboardIdx == -1 {
|
||||||
|
t.Fatalf("expected an onboarding invocation, got %v", lines)
|
||||||
|
}
|
||||||
|
if daemonRestartIdx == -1 {
|
||||||
|
t.Fatalf("expected a daemon restart before tui, got %v", lines)
|
||||||
|
}
|
||||||
|
if tuiIdx == -1 {
|
||||||
|
t.Fatalf("expected a tui invocation, got %v", lines)
|
||||||
|
}
|
||||||
|
if !(onboardIdx < daemonRestartIdx && daemonRestartIdx < tuiIdx) {
|
||||||
|
t.Fatalf("expected onboarding, then daemon restart, then tui; got %v", lines)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOpenclawEnsureGatewayReady_UsesDaemonStartFallback(t *testing.T) {
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
t.Skip("uses a POSIX shell test binary")
|
||||||
|
}
|
||||||
|
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
setTestHome(t, tmpDir)
|
||||||
|
t.Setenv("PATH", tmpDir)
|
||||||
|
|
||||||
|
portProbe, err := net.Listen("tcp", "127.0.0.1:0")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
port := portProbe.Addr().(*net.TCPAddr).Port
|
||||||
|
_ = portProbe.Close()
|
||||||
|
|
||||||
|
configDir := filepath.Join(tmpDir, ".openclaw")
|
||||||
|
if err := os.MkdirAll(configDir, 0o755); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
if err := os.WriteFile(filepath.Join(configDir, "openclaw.json"), []byte(fmt.Sprintf(`{
|
||||||
|
"wizard": {"lastRunAt": "2026-01-01T00:00:00Z"},
|
||||||
|
"gateway": {"port": %d, "mode": "local"}
|
||||||
|
}`, port)), 0o644); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
bin := filepath.Join(tmpDir, "openclaw")
|
||||||
|
if err := os.WriteFile(bin, []byte("#!/bin/sh\nprintf '%s\\n' \"$*\" >> \"$HOME/invocations.log\"\n"), 0o755); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
oldCanInstallDaemon := openclawCanInstallDaemon
|
||||||
|
openclawCanInstallDaemon = func() bool { return true }
|
||||||
|
defer func() { openclawCanInstallDaemon = oldCanInstallDaemon }()
|
||||||
|
|
||||||
|
triggeredBy := make(chan string, 1)
|
||||||
|
listenerReady := make(chan net.Listener, 1)
|
||||||
|
go func() {
|
||||||
|
invocationsPath := filepath.Join(tmpDir, "invocations.log")
|
||||||
|
deadline := time.Now().Add(5 * time.Second)
|
||||||
|
for time.Now().Before(deadline) {
|
||||||
|
data, err := os.ReadFile(invocationsPath)
|
||||||
|
if err == nil {
|
||||||
|
lines := strings.Split(strings.TrimSpace(string(data)), "\n")
|
||||||
|
for _, line := range lines {
|
||||||
|
if line != "daemon start" && line != "gateway run --force" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
ln, err := net.Listen("tcp", fmt.Sprintf("127.0.0.1:%d", port))
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
go func() {
|
||||||
|
for {
|
||||||
|
conn, err := ln.Accept()
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
_ = conn.Close()
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
triggeredBy <- line
|
||||||
|
listenerReady <- ln
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
time.Sleep(10 * time.Millisecond)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
|
c := &Openclaw{}
|
||||||
|
cleanup, _, gotPort, err := c.ensureGatewayReady(bin)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("ensureGatewayReady() error = %v", err)
|
||||||
|
}
|
||||||
|
defer cleanup()
|
||||||
|
if gotPort != port {
|
||||||
|
t.Fatalf("ensureGatewayReady() port = %d, want %d", gotPort, port)
|
||||||
|
}
|
||||||
|
|
||||||
|
var ln net.Listener
|
||||||
|
select {
|
||||||
|
case which := <-triggeredBy:
|
||||||
|
if which != "daemon start" {
|
||||||
|
t.Fatalf("expected daemon start fallback, got %q", which)
|
||||||
|
}
|
||||||
|
case <-time.After(2 * time.Second):
|
||||||
|
t.Fatal("timed out waiting for gateway startup trigger")
|
||||||
|
}
|
||||||
|
select {
|
||||||
|
case ln = <-listenerReady:
|
||||||
|
defer ln.Close()
|
||||||
|
case <-time.After(2 * time.Second):
|
||||||
|
t.Fatal("timed out waiting for test listener")
|
||||||
|
}
|
||||||
|
|
||||||
|
data, err := os.ReadFile(filepath.Join(tmpDir, "invocations.log"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
lines := strings.Split(strings.TrimSpace(string(data)), "\n")
|
||||||
|
if len(lines) == 0 || lines[0] != "daemon start" {
|
||||||
|
t.Fatalf("expected daemon start invocation, got %v", lines)
|
||||||
|
}
|
||||||
|
for _, line := range lines {
|
||||||
|
if line == "gateway run --force" {
|
||||||
|
t.Fatalf("did not expect gateway run fallback when daemon start succeeds, got %v", lines)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOpenclawEnv_StagesBundledPluginRuntimeDeps(t *testing.T) {
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
setTestHome(t, tmpDir)
|
||||||
|
t.Setenv("OPENAI_API_KEY", "should-be-cleared")
|
||||||
|
|
||||||
|
env := envSliceToMap(openclawEnv())
|
||||||
|
|
||||||
|
if env["OPENCLAW_PLUGIN_STAGE_DIR"] != filepath.Join(tmpDir, ".openclaw", "plugin-runtime-deps") {
|
||||||
|
t.Fatalf("OPENCLAW_PLUGIN_STAGE_DIR = %q, want %q", env["OPENCLAW_PLUGIN_STAGE_DIR"], filepath.Join(tmpDir, ".openclaw", "plugin-runtime-deps"))
|
||||||
|
}
|
||||||
|
if _, ok := env["OPENAI_API_KEY"]; ok {
|
||||||
|
t.Fatal("expected OPENAI_API_KEY to be cleared from openclaw environment")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestOpenclawInstallEnv_PreservesExplicitStageDirAndAddsEagerDeps(t *testing.T) {
|
||||||
|
t.Setenv("OPENCLAW_PLUGIN_STAGE_DIR", "/tmp/custom-stage")
|
||||||
|
|
||||||
|
env := envSliceToMap(openclawInstallEnv())
|
||||||
|
|
||||||
|
if env["OPENCLAW_PLUGIN_STAGE_DIR"] != "/tmp/custom-stage" {
|
||||||
|
t.Fatalf("OPENCLAW_PLUGIN_STAGE_DIR = %q, want %q", env["OPENCLAW_PLUGIN_STAGE_DIR"], "/tmp/custom-stage")
|
||||||
|
}
|
||||||
|
if env["OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"] != "1" {
|
||||||
|
t.Fatalf("OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS = %q, want %q", env["OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"], "1")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestEnsureOpenclawInstalled_UsesBundledPluginInstallEnv(t *testing.T) {
|
||||||
|
if runtime.GOOS == "windows" {
|
||||||
|
t.Skip("uses a POSIX shell test binary")
|
||||||
|
}
|
||||||
|
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
setTestHome(t, tmpDir)
|
||||||
|
t.Setenv("PATH", tmpDir)
|
||||||
|
|
||||||
|
writeScript := func(path, content string) {
|
||||||
|
t.Helper()
|
||||||
|
if err := os.WriteFile(path, []byte(content), 0o755); err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
openclawPath := filepath.Join(tmpDir, "openclaw")
|
||||||
|
npmScript := fmt.Sprintf(`#!/bin/sh
|
||||||
|
/usr/bin/env | /usr/bin/sort > "$HOME/npm-env.log"
|
||||||
|
/bin/cat > %q <<'EOF'
|
||||||
|
#!/bin/sh
|
||||||
|
exit 0
|
||||||
|
EOF
|
||||||
|
/bin/chmod +x %q
|
||||||
|
exit 0
|
||||||
|
`, openclawPath, openclawPath)
|
||||||
|
writeScript(filepath.Join(tmpDir, "npm"), npmScript)
|
||||||
|
writeScript(filepath.Join(tmpDir, "git"), "#!/bin/sh\nexit 0\n")
|
||||||
|
|
||||||
|
oldConfirmPrompt := DefaultConfirmPrompt
|
||||||
|
DefaultConfirmPrompt = func(prompt string, options ConfirmOptions) (bool, error) {
|
||||||
|
if prompt != "OpenClaw is not installed. Install with npm?" {
|
||||||
|
t.Fatalf("unexpected prompt: %q", prompt)
|
||||||
|
}
|
||||||
|
return true, nil
|
||||||
|
}
|
||||||
|
defer func() { DefaultConfirmPrompt = oldConfirmPrompt }()
|
||||||
|
|
||||||
|
openclawFreshInstall = false
|
||||||
|
bin, err := ensureOpenclawInstalled()
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("ensureOpenclawInstalled() error = %v", err)
|
||||||
|
}
|
||||||
|
if bin != "openclaw" {
|
||||||
|
t.Fatalf("ensureOpenclawInstalled() bin = %q, want %q", bin, "openclaw")
|
||||||
|
}
|
||||||
|
|
||||||
|
envData, err := os.ReadFile(filepath.Join(tmpDir, "npm-env.log"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatal(err)
|
||||||
|
}
|
||||||
|
env := envSliceToMap(strings.Split(strings.TrimSpace(string(envData)), "\n"))
|
||||||
|
if env["OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"] != "1" {
|
||||||
|
t.Fatalf("OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS = %q, want %q", env["OPENCLAW_EAGER_BUNDLED_PLUGIN_DEPS"], "1")
|
||||||
|
}
|
||||||
|
if env["OPENCLAW_PLUGIN_STAGE_DIR"] != filepath.Join(tmpDir, ".openclaw", "plugin-runtime-deps") {
|
||||||
|
t.Fatalf("OPENCLAW_PLUGIN_STAGE_DIR = %q, want %q", env["OPENCLAW_PLUGIN_STAGE_DIR"], filepath.Join(tmpDir, ".openclaw", "plugin-runtime-deps"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestOpenclawEdit(t *testing.T) {
|
func TestOpenclawEdit(t *testing.T) {
|
||||||
c := &Openclaw{}
|
c := &Openclaw{}
|
||||||
tmpDir := t.TempDir()
|
tmpDir := t.TempDir()
|
||||||
@@ -1227,6 +1580,18 @@ func TestOpenclawChannelsConfigured(t *testing.T) {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func envSliceToMap(entries []string) map[string]string {
|
||||||
|
env := make(map[string]string, len(entries))
|
||||||
|
for _, entry := range entries {
|
||||||
|
key, value, ok := strings.Cut(entry, "=")
|
||||||
|
if !ok {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
env[key] = value
|
||||||
|
}
|
||||||
|
return env
|
||||||
|
}
|
||||||
|
|
||||||
func TestOpenclawChannelSetupPreflight(t *testing.T) {
|
func TestOpenclawChannelSetupPreflight(t *testing.T) {
|
||||||
if runtime.GOOS == "windows" {
|
if runtime.GOOS == "windows" {
|
||||||
t.Skip("uses a POSIX shell test binary")
|
t.Skip("uses a POSIX shell test binary")
|
||||||
|
|||||||
Reference in New Issue
Block a user