Files
ollama/x/mlxrunner/mlx/dynamic.go
Daniel Hiltgen 8968740836 mlx: Improve M5 performance with NAX (#15345)
* mlx: Improve M5 performance with NAX

This modifies the Mac release to now have 2 builds of MLX for broader
compatibility while supporting the latest M5 hardware features.  NAX requires
building with xcode 26.2 and targetting support only for OS v26 and up.  Since
we want to support older MacOS versions as well, we now need 2 different MLX
builds and runtime detection logic to select the optimal version.  The newer
build will detect NAX missing at runtime, so it is safe to run on pre M5 macs.

* mac: prevent generate on cross-compiles

For some versions of Xcode, cmake builds are failing due to header problems in
cross-compiling during the generate phase.  Since generate is producing arch
independent generated output, we can skip this during cross-compiling.
2026-04-07 08:12:24 -07:00

254 lines
7.0 KiB
Go

package mlx
// #include "dynamic.h"
// #include "generated.h"
// #include <stdlib.h>
import "C"
import (
"fmt"
"io/fs"
"log/slog"
"os"
"path/filepath"
"runtime"
"sort"
"strconv"
"strings"
"unsafe"
)
var initError error
var initLoadError string
var initLoadedPath string
// CheckInit returns any error that occurred during MLX dynamic library initialization.
func CheckInit() error {
if initLoadedPath != "" {
slog.Debug("MLX dynamic library loaded", "path", initLoadedPath)
}
if initError != nil && initLoadError != "" {
slog.Error(initLoadError)
}
return initError
}
// tryLoadFromDir searches a directory for the mlxc shared library and loads it.
func tryLoadFromDir(dir string) bool {
// On Windows, MSVC produces mlxc.dll (no lib prefix)
// On Unix, it's libmlxc.so or libmlxc.dylib
pattern := "libmlxc.*"
if runtime.GOOS == "windows" {
pattern = "mlxc.*"
}
matches, err := fs.Glob(os.DirFS(dir), pattern)
if err != nil || len(matches) == 0 {
return false
}
for _, match := range matches {
path := filepath.Join(dir, match)
cPath := C.CString(path)
defer C.free(unsafe.Pointer(cPath))
var handle C.mlx_dynamic_handle
if C.mlx_dynamic_load(&handle, cPath) != 0 {
initLoadError = fmt.Sprintf("failed to load MLX dynamic library: path=%s", path)
continue
}
if C.mlx_dynamic_load_symbols(handle) != 0 {
initLoadError = fmt.Sprintf("failed to load MLX dynamic library symbols: path=%s", path)
C.mlx_dynamic_unload(&handle)
continue
}
initLoadedPath = path
return true
}
return false
}
// libOllamaRoots returns candidate directories for MLX dynamic libraries.
// Production: exe_dir/lib/ollama (dist tarball) and exe_dir (app bundle).
// Development: build/lib/ollama and build/*/lib/ollama.
func libOllamaRoots() []string {
var roots []string
// Production paths relative to executable
if exe, err := os.Executable(); err == nil {
if eval, err := filepath.EvalSymlinks(exe); err == nil {
exe = eval
}
exeDir := filepath.Dir(exe)
switch runtime.GOOS {
case "darwin":
roots = append(roots, filepath.Join(exeDir, "lib", "ollama"))
roots = append(roots, exeDir) // app bundle: Contents/Resources/
case "linux":
roots = append(roots, filepath.Join(exeDir, "..", "lib", "ollama"))
case "windows":
roots = append(roots, filepath.Join(exeDir, "lib", "ollama"))
}
}
// Development paths: build/lib/ollama and build/*/lib/ollama.
// Reverse-sort and filter the glob results so higher-versioned Metal
// builds (e.g., metal-v4) are tried before lower ones (metal-v3),
// and incompatible variants are skipped. Without this, alphabetical
// order would always pick v3 over v4 in dev builds.
for _, base := range repoBuildDirs() {
roots = append(roots, filepath.Join(base, "lib", "ollama"))
if matches, err := filepath.Glob(filepath.Join(base, "*", "lib", "ollama")); err == nil {
sort.Sort(sort.Reverse(sort.StringSlice(matches)))
for _, m := range matches {
// Extract the build dir name (e.g., "metal-v4" from "build/metal-v4/lib/ollama")
rel, _ := filepath.Rel(base, m)
variant := strings.SplitN(rel, string(filepath.Separator), 2)[0]
if isCompatibleMLXVariant(variant) {
roots = append(roots, m)
}
}
}
}
return roots
}
// repoBuildDirs returns candidate build/ directories relative to cwd and repo root.
func repoBuildDirs() []string {
var dirs []string
if cwd, err := os.Getwd(); err == nil {
dirs = append(dirs, filepath.Join(cwd, "build"))
for dir := cwd; ; {
if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
if dir != cwd {
dirs = append(dirs, filepath.Join(dir, "build"))
}
break
}
parent := filepath.Dir(dir)
if parent == dir {
break
}
dir = parent
}
}
return dirs
}
// prependLibraryPath prepends dir to the platform's dynamic library search
// path so the linker finds colocated libmlx before any stale copies.
// Called once after successful library load.
func prependLibraryPath(dir string) {
var envVar string
switch runtime.GOOS {
case "darwin":
envVar = "DYLD_LIBRARY_PATH"
case "linux":
envVar = "LD_LIBRARY_PATH"
default:
return
}
if existing := os.Getenv(envVar); existing != "" {
os.Setenv(envVar, dir+string(filepath.ListSeparator)+existing)
} else {
os.Setenv(envVar, dir)
}
}
func init() {
switch runtime.GOOS {
case "darwin", "linux", "windows":
default:
return
}
// OLLAMA_LLM_LIBRARY overrides variant selection (e.g., "mlx_metal_v3").
// When set to an mlx_* value, only that specific subdir is tried.
// The GGML runner ignores mlx_* values (see discover/runner.go).
forcedVariant, _ := os.LookupEnv("OLLAMA_LLM_LIBRARY")
if forcedVariant != "" && !strings.HasPrefix(forcedVariant, "mlx_") {
forcedVariant = "" // not an MLX variant, ignore
}
found := findMLXLibrary(forcedVariant)
if !found {
initError = fmt.Errorf("failed to load MLX dynamic library (searched: %v)", libOllamaRoots())
return
}
prependLibraryPath(filepath.Dir(initLoadedPath))
}
func findMLXLibrary(forcedVariant string) bool {
for _, root := range libOllamaRoots() {
if forcedVariant != "" {
if tryLoadFromDir(filepath.Join(root, forcedVariant)) {
return true
}
} else {
if tryLoadFromMLXSubdirs(root) {
return true
}
if tryLoadFromDir(root) {
return true
}
}
}
return false
}
// tryLoadFromMLXSubdirs globs for mlx_* subdirs within dir, filters out
// incompatible variants, tries the remainder in reverse sorted order (so
// higher-versioned variants are preferred), and returns true on first
// successful load.
func tryLoadFromMLXSubdirs(dir string) bool {
mlxDirs, err := filepath.Glob(filepath.Join(dir, "mlx_*"))
if err != nil || len(mlxDirs) == 0 {
return false
}
// Reverse sort: mlx_metal_v4 before mlx_metal_v3, mlx_cuda_v13 before v12
sort.Sort(sort.Reverse(sort.StringSlice(mlxDirs)))
for _, mlxDir := range mlxDirs {
if !isCompatibleMLXVariant(filepath.Base(mlxDir)) {
slog.Debug("skipping incompatible MLX variant", "dir", mlxDir)
continue
}
if tryLoadFromDir(mlxDir) {
return true
}
}
return false
}
// isCompatibleMLXVariant checks whether an MLX variant directory is
// compatible with the current OS. On macOS, dlopen does NOT enforce
// the deployment target for dynamically loaded libraries, so we must
// check compatibility ourselves to avoid loading Metal 4.x shaders
// on a Metal 3.x driver.
func isCompatibleMLXVariant(name string) bool {
if runtime.GOOS != "darwin" {
return true // non-macOS variants use dlopen failure for filtering
}
// Metal variant naming:
// Production: mlx_metal_v3, mlx_metal_v4
// Dev build: metal-v3, metal-v4
var verStr string
switch {
case strings.HasPrefix(name, "mlx_metal_v"):
verStr = strings.TrimPrefix(name, "mlx_metal_v")
case strings.HasPrefix(name, "metal-v"):
verStr = strings.TrimPrefix(name, "metal-v")
}
if verStr != "" {
metalVer, err := strconv.Atoi(verStr)
if err != nil {
return true // unknown format, try it
}
// Metal 4.x requires macOS 26+
if metalVer >= 4 && macOSMajorVersion() < 26 {
return false
}
}
return true
}