diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d1eba1dc..64a0c09e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -193,11 +193,13 @@ jobs: create-release: needs: [update-packages, create-metadata, publish-pypi, publish-npm] + # create release when we've published a new version to npm or pypi + # always() is needed to evaluate this condition even when dependency jobs are skipped + # See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif if: | - (needs.update-packages.outputs.changes_made == 'true' && always()) && - ((needs.publish-pypi.result == 'success' && needs.publish-npm.result == 'skipped') || - (needs.publish-pypi.result == 'skipped' && needs.publish-npm.result == 'success') || - (needs.publish-pypi.result == 'success' && needs.publish-npm.result == 'success')) + always() && + needs.update-packages.outputs.changes_made == 'true' && + (needs.publish-pypi.result == 'success' || needs.publish-npm.result == 'success') runs-on: ubuntu-latest environment: release permissions: