Trim low-value tests per review feedback

Removed ~29 tests that were adding noise rather than coverage:
- Registration boilerplate tests (16): redundant with registrations.test.ts
- Redundant role/type checks (3): consolidated into behavioral tests
- "Should not throw" tests (6): consolidated into single lifecycle test
- Constant identity tests (2): provided no safety net
- expect(true).toBe(true) test (1): replaced with actual assertion
- Weak capability test (1): removed, handler check already exists

Strengthened remaining tests:
- Resource templates test now verifies specific resource names
- File resources test now asserts registerResource was called

Test count: 124 → 95 (29 removed)
Coverage unchanged at ~71%

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Niels Kaspers
2026-02-06 22:59:19 +02:00
parent 9c0921276c
commit 0ca9921e20
5 changed files with 33 additions and 348 deletions

View File

@@ -22,20 +22,6 @@ function createMockServer() {
describe('Prompts', () => {
describe('simple-prompt', () => {
it('should register with correct name and config', () => {
const { mockServer } = createMockServer();
registerSimplePrompt(mockServer);
expect(mockServer.registerPrompt).toHaveBeenCalledWith(
'simple-prompt',
expect.objectContaining({
title: 'Simple Prompt',
description: 'A prompt with no arguments',
}),
expect.any(Function)
);
});
it('should return fixed message with no arguments', () => {
const { mockServer, handlers } = createMockServer();
registerSimplePrompt(mockServer);
@@ -55,34 +41,9 @@ describe('Prompts', () => {
],
});
});
it('should return message with user role', () => {
const { mockServer, handlers } = createMockServer();
registerSimplePrompt(mockServer);
const handler = handlers.get('simple-prompt')!;
const result = handler();
expect(result.messages).toHaveLength(1);
expect(result.messages[0].role).toBe('user');
});
});
describe('args-prompt', () => {
it('should register with correct name and config', () => {
const { mockServer } = createMockServer();
registerArgumentsPrompt(mockServer);
expect(mockServer.registerPrompt).toHaveBeenCalledWith(
'args-prompt',
expect.objectContaining({
title: 'Arguments Prompt',
description: 'A prompt with two arguments, one required and one optional',
}),
expect.any(Function)
);
});
it('should include city in message', () => {
const { mockServer, handlers } = createMockServer();
registerArgumentsPrompt(mockServer);
@@ -114,36 +75,12 @@ describe('Prompts', () => {
expect(result.messages[0].content.text).toBe("What's weather in New York?");
expect(result.messages[0].content.text).not.toContain(',');
});
it('should return message with user role', () => {
const { mockServer, handlers } = createMockServer();
registerArgumentsPrompt(mockServer);
const handler = handlers.get('args-prompt')!;
const result = handler({ city: 'Boston' });
expect(result.messages).toHaveLength(1);
expect(result.messages[0].role).toBe('user');
expect(result.messages[0].content.type).toBe('text');
});
});
describe('completable-prompt', () => {
it('should register with correct name and config', () => {
const { mockServer } = createMockServer();
registerPromptWithCompletions(mockServer);
expect(mockServer.registerPrompt).toHaveBeenCalledWith(
'completable-prompt',
expect.objectContaining({
title: 'Team Management',
description: 'First argument choice narrows values for second argument.',
}),
expect.any(Function)
);
});
it('should generate promotion message with department and name', () => {
const { mockServer, handlers } = createMockServer();
registerPromptWithCompletions(mockServer);
@@ -165,39 +102,15 @@ describe('Prompts', () => {
const salesResult = handler({ department: 'Sales', name: 'David' });
expect(salesResult.messages[0].content.text).toContain('Sales');
expect(salesResult.messages[0].content.text).toContain('David');
expect(salesResult.messages[0].role).toBe('user');
const marketingResult = handler({ department: 'Marketing', name: 'Grace' });
expect(marketingResult.messages[0].content.text).toContain('Marketing');
expect(marketingResult.messages[0].content.text).toContain('Grace');
});
it('should return message with user role', () => {
const { mockServer, handlers } = createMockServer();
registerPromptWithCompletions(mockServer);
const handler = handlers.get('completable-prompt')!;
const result = handler({ department: 'Support', name: 'John' });
expect(result.messages).toHaveLength(1);
expect(result.messages[0].role).toBe('user');
});
});
describe('resource-prompt', () => {
it('should register with correct name and config', () => {
const { mockServer } = createMockServer();
registerEmbeddedResourcePrompt(mockServer);
expect(mockServer.registerPrompt).toHaveBeenCalledWith(
'resource-prompt',
expect.objectContaining({
title: 'Resource Prompt',
description: 'A prompt that includes an embedded resource reference',
}),
expect.any(Function)
);
});
it('should return text resource reference', () => {
const { mockServer, handlers } = createMockServer();
registerEmbeddedResourcePrompt(mockServer);