Move utility plugins into their own folder. They don't go into the support folder because they're not standalone units and require interaction with the main units. Further refactoring pending.

lib/units/device/index.js

@@ -21,7 +21,6 @@ module.exports = function(options) {
         .dependency(require('./plugins/screen/stream'))
         .dependency(require('./plugins/screen/capture'))
         .dependency(require('./plugins/service'))
-        .dependency(require('./plugins/display'))
         .dependency(require('./plugins/browser'))
         .dependency(require('./plugins/store'))
         .dependency(require('./plugins/clipboard'))
@@ -34,7 +33,6 @@ module.exports = function(options) {
         .dependency(require('./plugins/cleanup'))
         .dependency(require('./plugins/reboot'))
         .dependency(require('./plugins/connect'))
-        .dependency(require('./plugins/data'))
         .dependency(require('./plugins/account'))
         .dependency(require('./plugins/ringer'))
         .dependency(require('./plugins/wifi'))

lib/units/device/plugins/account.js

@@ -6,7 +6,7 @@ var wireutil = require('../../../wire/util')
 
 module.exports = syrup.serial()
   .dependency(require('./service'))
-  .dependency(require('./identity'))
+  .dependency(require('./util/identity'))
   .dependency(require('./touch'))
   .dependency(require('../support/router'))
   .dependency(require('../support/push'))

lib/units/device/plugins/group.js

@@ -11,7 +11,7 @@ var lifecycle = require('../../../util/lifecycle')
 
 module.exports = syrup.serial()
   .dependency(require('./solo'))
-  .dependency(require('./identity'))
+  .dependency(require('./util/identity'))
   .dependency(require('./service'))
   .dependency(require('../support/router'))
   .dependency(require('../support/push'))

lib/units/device/plugins/screen/capture.js

@@ -13,7 +13,7 @@ module.exports = syrup.serial()
   .dependency(require('../../support/push'))
   .dependency(require('../../support/storage'))
   .dependency(require('../../resources/minicap'))
-  .dependency(require('../display'))
+  .dependency(require('../util/display'))
   .define(function(options, adb, router, push, storage, minicap, display) {
     var log = logger.createLogger('device:plugins:screen:capture')
     var plugin = Object.create(null)

lib/units/device/plugins/screen/stream.js

@@ -21,7 +21,7 @@ var FailCounter = require('../../../../util/failcounter')
 module.exports = syrup.serial()
   .dependency(require('../../support/adb'))
   .dependency(require('../../resources/minicap'))
-  .dependency(require('../display'))
+  .dependency(require('../util/display'))
   .dependency(require('./options'))
   .define(function(options, adb, minicap, display, screenOptions) {
     var log = logger.createLogger('device:plugins:screen:stream')

lib/units/device/plugins/solo.js

@@ -10,7 +10,7 @@ module.exports = syrup.serial()
   .dependency(require('../support/sub'))
   .dependency(require('../support/push'))
   .dependency(require('../support/router'))
-  .dependency(require('./identity'))
+  .dependency(require('./util/identity'))
   .define(function(options, sub, push, router, identity) {
     var log = logger.createLogger('device:plugins:solo')
 

lib/units/device/plugins/touch/index.js

@@ -19,7 +19,7 @@ module.exports = syrup.serial()
   .dependency(require('../../support/adb'))
   .dependency(require('../../support/router'))
   .dependency(require('../../resources/minitouch'))
-  .dependency(require('../flags'))
+  .dependency(require('../util/flags'))
   .define(function(options, adb, router, minitouch, flags) {
     var log = logger.createLogger('device:plugins:touch')
 

lib/units/device/plugins/util/data.js

@@ -1,7 +1,7 @@
 var syrup = require('stf-syrup')
 var deviceData = require('stf-device-db')
 
-var logger = require('../../../util/logger')
+var logger = require('../../../../util/logger')
 
 module.exports = syrup.serial()
   .dependency(require('./identity'))

lib/units/device/plugins/util/display.js

@@ -3,14 +3,14 @@ var util = require('util')
 var syrup = require('stf-syrup')
 var EventEmitter = require('eventemitter3').EventEmitter
 
-var logger = require('../../../util/logger')
-var streamutil = require('../../../util/streamutil')
+var logger = require('../../../../util/logger')
+var streamutil = require('../../../../util/streamutil')
 
 module.exports = syrup.serial()
-  .dependency(require('../support/adb'))
-  .dependency(require('../resources/minicap'))
-  .dependency(require('./service'))
-  .dependency(require('./screen/options'))
+  .dependency(require('../../support/adb'))
+  .dependency(require('../../resources/minicap'))
+  .dependency(require('../service'))
+  .dependency(require('../screen/options'))
   .define(function(options, adb, minicap, service, screenOptions) {
     var log = logger.createLogger('device:plugins:display')
 

lib/units/device/plugins/util/identity.js

@@ -1,10 +1,10 @@
 var syrup = require('stf-syrup')
 
-var devutil = require('../../../util/devutil')
-var logger = require('../../../util/logger')
+var devutil = require('../../../../util/devutil')
+var logger = require('../../../../util/logger')
 
 module.exports = syrup.serial()
-  .dependency(require('../support/properties'))
+  .dependency(require('../../support/properties'))
   .dependency(require('./display'))
   .dependency(require('./phone'))
   .define(function(options, properties, display, phone) {

lib/units/device/plugins/util/phone.js

@@ -1,9 +1,9 @@
 var syrup = require('stf-syrup')
 
-var logger = require('../../../util/logger')
+var logger = require('../../../../util/logger')
 
 module.exports = syrup.serial()
-  .dependency(require('./service'))
+  .dependency(require('../service'))
   .define(function(options, service) {
     var log = logger.createLogger('device:plugins:phone')
 

lib/units/device/plugins/util/urlformat.js

@@ -3,8 +3,8 @@ var _ = require('lodash')
 var tr = require('transliteration')
 
 module.exports = syrup.serial()
-  .dependency(require('../identity'))
-  .dependency(require('../data'))
+  .dependency(require('./identity'))
+  .dependency(require('./data'))
   .define(function(options, identity, data) {
     function createSlug() {
       var model = identity.model