starred/stf-DeviceFarmer
1
0
Fork 0
mirror of https://github.com/DeviceFarmer/stf.git synced 2026-04-26 15:55:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't open modal box if it doesn't have a big photo.

Browse Source
This commit is contained in:
Gunther Brunner
2014-09-12 19:32:35 +09:00
parent a4a46fc48b
commit bd7035c670
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
res/app/control-panes/info/info.jade
View File

@@ -17,7 +17,7 @@
tr tr
td(translate) Place td(translate) Place
td {{device.provider.name}} td {{device.provider.name}}
tr tr(ng-show='device.name && device.image')
td td
td td
button(ng-click='openDevicePhoto(device)').btn.btn-xs.btn-primary-outline button(ng-click='openDevicePhoto(device)').btn.btn-xs.btn-primary-outline
@@ -61,6 +61,9 @@
.widget-content.padded-small .widget-content.padded-small
table.table.table-condensed.table-hover.table-infocard table.table.table-condensed.table-hover.table-infocard
tbody tbody
tr
td(translate) Size
td {{device.display.inches}}''
tr tr
td(translate) Density td(translate) Density
td {{device.display.density | displayDensity}} td {{device.display.density | displayDensity}}

8
res/app/device-list/device-list-details-directive.js
View File

@@ -68,9 +68,11 @@ module.exports = function DeviceListDetailsDirective(
var id = e.target.parentNode.parentNode.parentNode.id var id = e.target.parentNode.parentNode.parentNode.id
var device = mapping[id] var device = mapping[id]
var title = device.name if (device.name && device.image) {
var enhancedPhoto800 = '/static/app/devices/photo/x800/' + device.image var title = device.name
LightboxImageService.open(title, enhancedPhoto800) var enhancedPhoto800 = '/static/app/devices/photo/x800/' + device.image
LightboxImageService.open(title, enhancedPhoto800)
}
} }
} }