mirror of
https://github.com/DeviceFarmer/stf.git
synced 2026-04-23 06:15:16 +02:00
Make TransactionService a bit more convenient for single-device use cases.
This commit is contained in:
@@ -7,7 +7,7 @@ module.exports = function ControlServiceFactory(
|
||||
var controlService = {
|
||||
}
|
||||
|
||||
function ControlService(devices, channel) {
|
||||
function ControlService(target, channel) {
|
||||
var keyCodes = {
|
||||
8: 8 // backspace
|
||||
, 13: 13 // enter
|
||||
@@ -79,7 +79,7 @@ module.exports = function ControlServiceFactory(
|
||||
}
|
||||
|
||||
this.shell = function(command) {
|
||||
var tx = TransactionService.create(devices)
|
||||
var tx = TransactionService.create(target)
|
||||
socket.emit('shell.command', channel, tx.channel, {
|
||||
command: command
|
||||
, timeout: 10000
|
||||
@@ -88,7 +88,7 @@ module.exports = function ControlServiceFactory(
|
||||
}
|
||||
|
||||
this.identify = function() {
|
||||
var tx = TransactionService.create(devices)
|
||||
var tx = TransactionService.create(target)
|
||||
socket.emit('device.identify', channel, tx.channel)
|
||||
return tx
|
||||
}
|
||||
@@ -102,7 +102,7 @@ module.exports = function ControlServiceFactory(
|
||||
.then(function(response) {
|
||||
var manifest = response.data.manifest
|
||||
var app = manifest.application
|
||||
var tx = TransactionService.create(devices)
|
||||
var tx = TransactionService.create(target)
|
||||
var params = {
|
||||
url: response.data.url
|
||||
}
|
||||
@@ -121,12 +121,8 @@ module.exports = function ControlServiceFactory(
|
||||
}
|
||||
}
|
||||
|
||||
controlService.forOne = function(device, channel) {
|
||||
return new ControlService([device], channel)
|
||||
}
|
||||
|
||||
controlService.forMany = function(devices, channel) {
|
||||
return new ControlService(devices, channel)
|
||||
controlService.create = function(target, channel) {
|
||||
return new ControlService(target, channel)
|
||||
}
|
||||
|
||||
return controlService
|
||||
|
||||
@@ -8,7 +8,7 @@ module.exports = function TransactionServiceFactory(socket) {
|
||||
return 'tx.' + uuid.v4()
|
||||
}
|
||||
|
||||
function Transaction(devices) {
|
||||
function MultiDeviceTransaction(devices) {
|
||||
var pending = Object.create(null)
|
||||
, results = []
|
||||
, channel = createChannel()
|
||||
@@ -49,6 +49,43 @@ module.exports = function TransactionServiceFactory(socket) {
|
||||
})
|
||||
}
|
||||
|
||||
function SingleDeviceTransaction(device) {
|
||||
var pending = new PendingTransactionResult(device)
|
||||
, result = pending.result
|
||||
, channel = createChannel()
|
||||
|
||||
function doneListener(someChannel, data) {
|
||||
if (someChannel === channel) {
|
||||
pending.done(data)
|
||||
}
|
||||
}
|
||||
|
||||
function progressListener(someChannel, data) {
|
||||
if (someChannel === channel) {
|
||||
pending.progress(data)
|
||||
}
|
||||
}
|
||||
|
||||
socket.on('tx.done', doneListener)
|
||||
socket.on('tx.progress', progressListener)
|
||||
|
||||
this.channel = channel
|
||||
this.result = result
|
||||
this.results = [result]
|
||||
this.promise = pending.promise
|
||||
.finally(function() {
|
||||
socket.removeListener('tx.done', doneListener)
|
||||
socket.removeListener('tx.progress', progressListener)
|
||||
socket.emit('tx.cleanup', channel)
|
||||
})
|
||||
.progressed(function() {
|
||||
return result
|
||||
})
|
||||
.then(function() {
|
||||
return result
|
||||
})
|
||||
}
|
||||
|
||||
function PendingTransactionResult(device) {
|
||||
var resolver = Promise.defer()
|
||||
, result = new TransactionResult(device)
|
||||
@@ -123,8 +160,13 @@ module.exports = function TransactionServiceFactory(socket) {
|
||||
this.lastData = null
|
||||
}
|
||||
|
||||
transactionService.create = function(devices) {
|
||||
return new Transaction(devices)
|
||||
transactionService.create = function(target) {
|
||||
if (Array.isArray(target)) {
|
||||
return new MultiDeviceTransaction(target)
|
||||
}
|
||||
else {
|
||||
return new SingleDeviceTransaction(target)
|
||||
}
|
||||
}
|
||||
|
||||
return transactionService
|
||||
|
||||
Reference in New Issue
Block a user