Fix error-catch problem and some refactoring.

This commit is contained in:
Valverde Antonio
2014-07-30 16:45:17 +09:00
parent 4a6d375adc
commit daa1faaa29
5 changed files with 24 additions and 24 deletions

View File

@@ -49,7 +49,7 @@ module.exports = syrup.serial()
, reply.okay()
])
})
.error(function(err) {
.catch(function(err) {
log.error('Account removal failed', err.stack)
push.send([
channel
@@ -71,7 +71,7 @@ module.exports = syrup.serial()
, reply.okay()
])
})
.error(function(err) {
.catch(function(err) {
log.error('Add account menu failed', err.stack)
push.send([
channel

View File

@@ -22,7 +22,7 @@ module.exports = syrup.serial()
, reply.okay(mounted ? 'sd_mounted' : 'sd_unmounted')
])
})
.error(function(err) {
.catch(function(err) {
log.error('Getting SD card Status', err.stack)
push.send([
channel

View File

@@ -507,20 +507,20 @@ module.exports = syrup.serial()
plugin.removeAccount = function(data) {
return runServiceCommand(
apk.wire.MessageType.DO_REMOVE_ACCOUNT
, new apk.wire.DoRemoveAccountRequest({
type: data.type
, account: data.account
})
)
.timeout(15000)
.then(function(data) {
var response = apk.wire.DoRemoveAccountResponse.decode(data)
if (response.success) {
return true
}
throw new Error('Unable to remove account')
apk.wire.MessageType.DO_REMOVE_ACCOUNT
, new apk.wire.DoRemoveAccountRequest({
type: data.type
, account: data.account
})
)
.timeout(15000)
.then(function(data) {
var response = apk.wire.DoRemoveAccountResponse.decode(data)
if (response.success) {
return true
}
throw new Error('Unable to remove account')
})
}
plugin.addAccountMenu = function() {

View File

@@ -22,7 +22,7 @@ module.exports = syrup.serial()
, reply.okay()
])
})
.error(function(err) {
.catch(function(err) {
log.error('Setting Wifi enabled failed', err.stack)
push.send([
channel
@@ -42,7 +42,7 @@ module.exports = syrup.serial()
, reply.okay(enabled ? 'wifi_enabled' : 'wifi_disabled')
])
})
.error(function(err) {
.catch(function(err) {
log.error('Getting Wifi status failed', err.stack)
push.send([
channel

View File

@@ -54,13 +54,13 @@ enum MessageType {
RebootMessage = 52;
ConnectStartMessage = 53;
ConnectStopMessage = 54;
AccountRemoveMessage = 55;
RingerSetMessage = 56;
WifiSetEnabledMessage = 57;
WifiGetStatusMessage = 58;
AccountAddMenuMessage = 59;
AccountAddMessage = 60;
AccountGetMessage = 62;
AccountRemoveMessage = 55;
SdStatusMessage = 61;
}
@@ -391,11 +391,6 @@ message ConnectStartMessage {
message ConnectStopMessage {
}
message AccountRemoveMessage {
required string type = 1;
optional string account = 2;
}
message AccountAddMenuMessage {
}
@@ -408,6 +403,11 @@ message AccountGetMessage {
required string type = 1;
}
message AccountRemoveMessage {
required string type = 1;
optional string account = 2;
}
message SdStatusMessage {
}