APPSTATE refactoring:

- Make index.html cacheable by being stateless
- Improve compression (base64 doesn't gzip well)
- Remove base64 encoding/decoding step
- Make AppState injectable so it can be unit tested
- Ready to remove the global leakage

res/app/components/stf/app-state/app-state-provider.js

@@ -0,0 +1,24 @@
+module.exports = function AppStateProvider() {
+  var values = {
+    config: {
+      websocketUrl: ''
+    },
+    user: {
+      settings: {}
+    }
+  }
+
+  /*globals GLOBAL_APPSTATE:false*/
+  if (GLOBAL_APPSTATE) {
+    values = angular.extend(values, GLOBAL_APPSTATE)
+  }
+
+  return {
+    set: function (constants) {
+      angular.extend(values, constants)
+    },
+    $get: function () {
+      return values
+    }
+  }
+}

res/app/components/stf/app-state/index.js

@@ -0,0 +1,3 @@
+module.exports = angular.module('stf.app-state', [
+])
+  .provider('AppState', require('./app-state-provider.js'))

res/app/components/stf/socket/index.js

@@ -1,5 +1,6 @@
 module.exports = angular.module('stf/socket', [
   //TODO: Refactor version update out to its own Ctrl
+  require('stf/app-state').name,
   require('stf/common-ui/modals/version-update').name
 ])
   .factory('socket', require('./socket-service'))

res/app/components/stf/socket/socket-service.js

@@ -1,46 +1,42 @@
 var io = require('socket.io')
 
-module.exports = function SocketFactory($rootScope, VersionUpdateService) {
-  /*globals APPSTATE:false*/
-  //TODO: Refactor APPSTATE to AppStateConstant
-  var websocketUrl = APPSTATE && APPSTATE.config &&
-    APPSTATE.config.websocketUrl ? APPSTATE.config.websocketUrl : ''
+module.exports =
+  function SocketFactory($rootScope, VersionUpdateService, AppState) {
+    var websocketUrl = AppState.config.websocketUrl || ''
 
-  var socket = io(websocketUrl, {
-    reconnection: false
-  , transports: ['websocket']
-  })
+    var socket = io(websocketUrl, {
+      reconnection: false, transports: ['websocket']
+    })
 
-  socket.scoped = function($scope) {
-    var listeners = []
+    socket.scoped = function ($scope) {
+      var listeners = []
 
-    $scope.$on('$destroy', function() {
-      listeners.forEach(function(listener) {
-        socket.removeListener(listener.event, listener.handler)
+      $scope.$on('$destroy', function () {
+        listeners.forEach(function (listener) {
+          socket.removeListener(listener.event, listener.handler)
+        })
+      })
+
+      return {
+        on: function (event, handler) {
+          listeners.push({
+            event: event, handler: handler
+          })
+          socket.on(event, handler)
+          return this
+        }
+      }
+    }
+
+    socket.on('outdated', function () {
+      VersionUpdateService.open()
+    })
+
+    socket.on('socket.ip', function (ip) {
+      $rootScope.$apply(function () {
+        socket.ip = ip
       })
     })
 
-    return {
-      on: function(event, handler) {
-        listeners.push({
-          event: event
-        , handler: handler
-        })
-        socket.on(event, handler)
-        return this
-      }
-    }
+    return socket
   }
-
-  socket.on('outdated', function () {
-    VersionUpdateService.open()
-  })
-
-  socket.on('socket.ip', function(ip) {
-    $rootScope.$apply(function() {
-      socket.ip = ip
-    })
-  })
-
-  return socket
-}

res/app/components/stf/user/index.js

@@ -1,2 +1,4 @@
-module.exports = angular.module('stf/user', [])
-  .factory('UserService', require('./user-service'))
+module.exports = angular.module('stf/user', [
+  require('stf/app-state').name
+])
+  .factory('UserService', require('./user-service'))

res/app/components/stf/user/user-service.js

@@ -1,6 +1,5 @@
-module.exports = function UserServiceFactory() {
-  /*global APPSTATE:false*/
+module.exports = function UserServiceFactory(AppState) {
   var userService = {}
-  userService.currentUser = APPSTATE.user
+  userService.currentUser = AppState.user
   return userService
 }